search

spine / spine-rails

Spine plugin for Rails
171 stars 38 forks source link

The current version will not work with Rails 4. #53

Closed hazah closed 10 years ago

hazah commented 10 years ago

This is an update to use the v1.3.0 of spine, so that the coffescripts compile properly and produce the expected JS.

ch1ago commented 10 years ago

I am currently evaluating front-end frameworks for our company. Without this patch spine-rails won't load in Rails4. Thanks @hazah :heart:

@maccman please check this patch for merging :+1:

hazah commented 10 years ago

@yakko My pleasure.

ch1ago commented 10 years ago

@aeischeid @cengebretson @adambiggs some love in here guys :heart:

jona commented 10 years ago

I'm in need of rails 4 support as well. This would be great! @hazah how heavily have you tested your changes?

hazah commented 10 years ago

The main change is that it goes from not working at all to working as advertized. However I've not inspected every nook and cranny. I'm fairly certain it's as tested as the actual spine framework of this version since this gem does nothing except incorporate those files into the pipeline.

aeischeid commented 10 years ago

normally @zohararad or @b3njamin are the maintainers here. I do not use spine-rails at all, but I can merge this if needed. It seems fairly safe.

zohararad commented 10 years ago

I'm happy to merge but since I have no way of publishing the Gem (not does @b3njamin afaik) maintaing this repo is a bit of a no-go and I'm sorry to say I haven't actively touched it for a very long while

aeischeid commented 10 years ago

@maccman are you able to publish gems? We've had some requests for an update to the spine rails gem

ch1ago commented 10 years ago

@gertig please take a look at it ASAP

hazah commented 10 years ago

Whomever is involved, please understand that this gem is completely useless with the current coffeescript environment, so an official release is absolutely necessary for any forward motion.

hazah commented 10 years ago

Just curious to know, when will this gem be updated on rubygems.org? Cheers.

aeischeid commented 10 years ago

I have zero experience with publishing gems. @maccman was the originator so he may have some idea how to do this or know someone who does and cares to take the time, other than that you might want to find other people who would have the skills and time. I would be happy to add someone as a maintainer of this if they wanted to fill that role.

hazah commented 10 years ago

@aeischeid If the only problem with publishing the gem is account access, then I wouldn't mind pushing that though for you, provided you can give me the access I'd need. Gotta learn at some point :)

aeischeid commented 10 years ago

@hazah I can add you as a contributor for this project if that is what you mean

hazah commented 10 years ago

@aeischeid For rubygems? Because that's all I'm aiming to do. Push this new version to be available for all. If that's what you mean then I'm game.

aeischeid commented 10 years ago

@hazah it's done, push some gems!