maccman
commented
12 years ago Thanks - but could I ask you to:
- Use the existing title helper
- Use the following pattern for detecting titles:
<%= yield(:title) || "Spine" %></li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/riklomas"><img src="https://avatars.githubusercontent.com/u/13360?v=4" />riklomas</a> commented <strong> 12 years ago</strong> </div> <div class="markdown-body"> <p>It is currently using the existing title helpers for pages that have them, I can put them on pages without though. The tag you've suggested wouldn't be as good for SEO, e.g. on <a href="http://spinejs.com/docs/models">http://spinejs.com/docs/models</a>, it would give a title of "Models", rather than "Models - Documentation - Spine"</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/evidens"><img src="https://avatars.githubusercontent.com/u/126888?v=4" />evidens</a> commented <strong> 12 years ago</strong> </div> <div class="markdown-body"> <p>This addition or something similar would be great. I'm learning Spine now and have five tabs, all with 'Spine' which makes it harder to find the right one for reference. Thanks for this framework, it looks great!</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
Been having trouble finding information through Google/Chrome integrated search bar, most of the problems can be fixed with some proper page titles for better SEO