search

spinen / laravel-clickup

SPINEN's Laravel Package for ClickUp.
27 stars 14 forks source link

Support phpdotenv v5 #15

Closed ssfinney closed 3 years ago

ssfinney commented 3 years ago

This is to support Laravel v8 which requires this version

ssfinney commented 3 years ago

@jimmypuckett FYI, I hit a major problem with supporting Laravel 8 in this package.

Laravel 8 requires vlucas/phpdotenv v5, but Laravel 7 only allows vlucas/phpdotenv v4, and of course there's a big breaking change between versions 4-5. When the user is on Laravel 7, composer tries to pull phpdotenv v5 and the Env facade from illuminate/support breaks and our tests fail.

We have to require the phpdotenv package though, for our configs to load properly.

Therefore I have to split the package to a new major version starting at Laravel 8+, PHP 7.3+, and phpdotenv 5.0+.