spinicist / QUIT

A set of tools for processing Quantitative MR Images
Mozilla Public License 2.0
58 stars 20 forks source link

documentation improvement: glibc version #23

Closed seareel closed 4 years ago

seareel commented 4 years ago

A suggestion for improving the main README.md

in the installation section, some part reads:

The Linux binaries are built with Ubuntu 14.04 with GCC 6. If you need to run on an older version of Linux with a previous version of glibc then you will need to compile from source.

The version of glibc is not specifically mentioned, just the distro and compiler version. Adding the glibc version corresponding to Ubuntu 14.04 would make the version limitation clearer, in particular if someone is using another distribution with a different glibc schedule. I believe Ubuntu 14.04 shipped with glibc 2.19.

Thanks for the great code !

spinicist commented 4 years ago

Hello,

Thanks for pointing this out. The problem with updating the README is that the compiled binaries are actually very out of date at this point. I swapped to C++17 sometime ago and hence on Linux GCC > 7 is now required. When I made the swap I didn't manage to compile up the binaries because getting GCC 7 on Travis was impossible. Azure pipelines should now have GCC 7 but I haven't had time to look into swapping over.

I'm going to leave this issue open for the time being. If you (or anyone else) has the time to file a PR with either a Travis or Azure Pipeline that can build master on Linux, I will very happily merge it.

spinicist commented 4 years ago

Hello,

I have finally found time to fix the CI builds and update a lot of things. There are new pre-built binaries available on the releases page, which are now built with Ubuntu 16.04 and I think glibc 2.3 - to be honest, trying to decipher the output of readelf and ldd is right at the edge of my understanding. I have made a note in the README about the glibc version. I will finally close this issue, feel free to re-open it or make any new ones if you find a problem.