`spin k8s scaffold`: image pull secret support

spinkube / spin-plugin-kube

A Spin plugin for interacting with Kubernetes.

Other

27 stars 7 forks source link

`spin k8s scaffold`: image pull secret support #30

Closed bacongobbler closed 8 months ago

bacongobbler commented 8 months ago

ImagePullSecrets is a list of references to secrets in the same namespace to use for pulling the image.

https://github.com/spinkube/spin-operator/blob/a401e4932595f7dd9d7980067f75bf075a4b0eec/config/crd/bases/core.spinoperator.dev_spinapps.yaml#L217C15-L233

bacongobbler commented 8 months ago

Marking as a nice-to-have. Users can take the output of spin k8s scaffold --from my-private-oci-registry.com/myapp:1.0.0 and add imagePullSecret metadata afterwards. A CLI option would make this a lot easier though!

rajatjindal commented 8 months ago

Hi @bacongobbler - if no one is working on this, I can pick this up. kindly let me know. thanks

bacongobbler commented 8 months ago

Go for it.

rajatjindal commented 8 months ago

fixed in #41