search

spinkube / spin-plugin-kube

A Spin plugin for interacting with Kubernetes.
Other
27 stars 7 forks source link

auto update plugin manifest in index repo on tagged releases #56

Closed rajatjindal closed 8 months ago

rajatjindal commented 8 months ago

I see this action also runs for pushes to branches matching "v[0-9]+.[0-9]+" -- just double-checking that the 'Release Plugin' step should run in these cases as well.

that is a good point. I don't think we need to run this action for "v[0-9]+.[0-9]+"` unless there is a specific requirement. do you see any issue if we just remove that part from the trigger config?

vdice commented 8 months ago

do you see any issue if we just remove that part from the trigger config?

No, althought I haven't really been tuned in to this repo and its CI needs. But if we we don't need that trigger for this workflow, sounds good, we should remove.

bacongobbler commented 8 months ago

I don't think we need to run this action for "v[0-9]+.[0-9]+"` unless there is a specific requirement.

I'm confused. I thought that was the whole point of this PR. If we tag v0.1.0, this change will now add v0.1.0 to the index.

Can you please help catch me up on the context behind this change?

bacongobbler commented 8 months ago

Oh wait you're talking about BRANCHES, not tags. Sounds good to me!