search

spinnaker-plugins / aws-lambda-deployment-plugin-spinnaker

Spinnaker plugin to support deployment of AWS Lambda functions via Spinnaker pipelines
Apache License 2.0
23 stars 22 forks source link

feat(aws.routingStage): Fix order of executing tasks first update or … #118

Closed Avi1235 closed 2 years ago

Avi1235 commented 2 years ago

There is an issue where you can’t update provisioned concurrency when deploying a new lamba version and doing a routingStage to move the weights of the alias to the newly deployed version.

Screen Shot 2022-07-08 at 1 09 34 PM

The issue is occurring because routing the weights takes some time to complete and while the weights are distributed between two versions requesting to update provisioned concurrency is prevented by AWS.

The aws console suggest to update provisioned before routing.

Screen Shot 2022-07-08 at 1 08 19 PM
dbyron-sf commented 2 years ago

Possible to add tests for this?

Avi1235 commented 2 years ago

Sure

Avi1235 commented 2 years ago

Hi @dbyron-sf could you review? its not letting me add reviewers

dbyron-sf commented 2 years ago

I'm slammed with internal stuff at the moment...I'll try to get to it, but it probably won't be til next week at the earliest.

Avi1235 commented 2 years ago

I'm slammed with internal stuff at the moment...I'll try to get to it, but it probably won't be til next week at the earliest.

Got it. Thank you for the quick reply!

Avi1235 commented 2 years ago

FYI: will close this PR and open another that validates alias weights before updating concurrency instead of changing the order of request