search

spinnaker-plugins / aws-lambda-deployment-plugin-spinnaker

Spinnaker plugin to support deployment of AWS Lambda functions via Spinnaker pipelines
Apache License 2.0
23 stars 22 forks source link

feat(aws.routingStage): validate that weights are fully moved before … #119

Closed Avi1235 closed 2 years ago

Avi1235 commented 2 years ago

There is an issue where you can’t update provisioned concurrency when deploying a new lamba version and doing a routingStage.

Screen Shot 2022-07-08 at 1 09 34 PM

The issue is occurring because routing the weights takes some time to complete and while the weights are distributed between two versions requesting to update provisioned concurrency is prevented by AWS. The solution was to validate that the weights are fully moved after executing LambdaTrafficUpdateTask and before executing LambdaPutConcurrencyTask.

Doing a LambdaTrafficUpdate with $WEIGHTED Strategy remains the same

Avi1235 commented 2 years ago

@dbyron-sf hey are you free to review today?

Avi1235 commented 2 years ago

@claymccoy @link108 review this PR if you have spare time, Thanks!

Avi1235 commented 2 years ago

FYI: im pinging because i cannot add reviewers sorry to bother