search

spinnaker-plugins / aws-lambda-deployment-plugin-spinnaker

Spinnaker plugin to support deployment of AWS Lambda functions via Spinnaker pipelines
Apache License 2.0
23 stars 22 forks source link

Add update code stage #52

Closed mikael-lindstrom closed 3 years ago

mikael-lindstrom commented 3 years ago

This PR adds a stage that only updates the code for a Lambda function. The reason for this is that we want to control everything else from terraform and only use Spinnaker for updating code, publishing new versions and route traffic.

shyamsfo commented 3 years ago

Does the existing Deployment stage not already do this? If the function already exists it only updates the code on it. Do we need a separate stage for this? Otherwise looks good.

mikael-lindstrom commented 3 years ago

Does the existing Deployment stage not already do this? If the function already exists it only updates the code on it. Do we need a separate stage for this? Otherwise looks good.

The Deployment stage works fine but we create our Lambda functions, IAM roles etc using terraform. This stage allows us to still keep that but use Spinnaker for updating the code, test the new version and then route traffic to it.

Thanks for the merge 👍

shyamsfo commented 3 years ago

Seems to work well !! Nice...

On Tue, Jan 26, 2021 at 5:26 PM Mikael Lindström notifications@github.com wrote:

Does the existing Deployment stage not already do this? If the function already exists it only updates the code on it. Do we need a separate stage for this? Otherwise looks good.

The Deployment stage works fine but we create our Lambda functions, IAM roles etc using terraform. This stage allows us to still keep that but use Spinnaker for updating the code, test the new version and then route traffic to it.

Thanks for the merge 👍

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/spinnaker-plugins/aws-lambda-deployment-plugin-spinnaker/pull/52#issuecomment-767855155, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDTJ343HVE7FFAUTNPSQWTS346LVANCNFSM4WQQSG4Q .

shyamsfo commented 3 years ago

Seems to work fine...