search

spinnaker-plugins / aws-lambda-deployment-plugin-spinnaker

Spinnaker plugin to support deployment of AWS Lambda functions via Spinnaker pipelines
Apache License 2.0
23 stars 22 forks source link

Additional stream event source mapping properties #62

Closed jaredstehler closed 3 years ago

jaredstehler commented 3 years ago

Adds properties:

depends on https://github.com/spinnaker/clouddriver/pull/5319

jaredstehler commented 3 years ago

Null values would behave similarly to no input. I think you are right that we should send null for blank strings, like I had to do for the tumbling window value. I’ll make that change.

On Sat, Mar 27, 2021 at 10:11 AM Shyam M @.***> wrote:

@.**** commented on this pull request.

Looks good. Did you test these when the testInput does not have these parameters. Does it handle nulls correctly? Are you sure you dont need the equivalent of StringUtils.isNullOrEmpty around these?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spinnaker-plugins/aws-lambda-deployment-plugin-spinnaker/pull/62#pullrequestreview-622652816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPNWSUW45DCBXHCPIOGQRDTFXRSTANCNFSM4Z3U3J7A .

jaredstehler commented 3 years ago

updated PR based on comments @shyamsfo