search

spinnaker-plugins / aws-lambda-deployment-plugin-spinnaker

Spinnaker plugin to support deployment of AWS Lambda functions via Spinnaker pipelines
Apache License 2.0
23 stars 22 forks source link

fix(verify): Lambda Pending state fix #82

Closed nimakaviani closed 3 years ago

nimakaviani commented 3 years ago

A pending state for a lambda function prevents routing traffic or attaching event sources. The earlier fix with waiting for it to stablize still applies but needs to be pushed further up in order for it to happen before we try to attach event sources etc.

fixes #70

nimakaviani commented 3 years ago

@coleduclos I tried with us-east-1 and same fix that I made works. Only change was that it had to be pushed right before Lambda Create Task for it to make sure a transition Pending -> Active right after creation.

The oversight was that, in the absence of an event source, you dont need a function in an Active state until right before routing traffic.

coleduclos commented 3 years ago

@nimakaviani awesome! Thank you again for the quick turn around. We will begin to test these changes ASAP