search

spinnaker-plugins / aws-lambda-deployment-plugin-spinnaker

Spinnaker plugin to support deployment of AWS Lambda functions via Spinnaker pipelines
Apache License 2.0
23 stars 22 forks source link

Event Source Mapping isn't deleted #85

Closed eyalle closed 3 years ago

eyalle commented 3 years ago

After creating a function, and attaching an ARN for EventSourceMappingsTrigger, everything works as expected. When re-triggering the job, and removing the ARN, does not remove the attachment (only after another re-run). This was tested a few times, when triggering without an ARN, we're setting eventSourceMappings to an empty list, to verify the mappings are cleared as well. This still doesn't work on the first run.

some more info: running version 1.0.6 AWS region = us-west-2 Trigger type tested - SQS\Kinesis

Reproducing

  1. Run the plugin & create a function using a trigger ARN
  2. Re-run the plugin without the ARN from previous step
  3. AWS Console should still show the EventTriggering config
  4. Re-run the plugin again without the ARN from step 1
  5. AWS console should show no EventTriggers attached
nimakaviani commented 3 years ago

@eyalle can you please confirm that this is still an issue with v1.0.8 of the plugin, and if so we will look into fixing this next.

eyalle commented 3 years ago

@nimakaviani I believe this is solved, but we're working on stabilising some of our tests and will be able to run some more extensive tests in the next few days (hopefully) I can say, that personally I haven't encountered this issue in a some time

eyalle commented 3 years ago

@nimakaviani haven't envountered it so far, closing the issue. Thank you 🙏

nimakaviani commented 3 years ago

thanks for the update!