spinnaker-plugins / aws-lambda-deployment-plugin-spinnaker

Spinnaker plugin to support deployment of AWS Lambda functions via Spinnaker pipelines

Apache License 2.0

23 stars 22 forks source link

Environment variables should allow "_" (underscore) in the environment variable name. #87

Closed eyal-mor closed 3 years ago

eyal-mor commented 3 years ago

Failing to update environment variables via the plugin when the env variable name contains and _ character (underscore) Pasted_Image_25_07_2021__16_02

AWS allows this case.

Reproducing

Set environment variables to {"c_c": "c_c"}. This will fail the assertion but passes on AWS.

nimakaviani commented 3 years ago

what does the pipeline look like?
is it from a second deploy? or an update stage?
which verification task in the pipeline is failing?

eyalle commented 3 years ago

@nimakaviani thank you for looking into it, and apologies for not adding info until now. I'm going to close this issue out, I wasn't able to reproduce this any longer. I believe some of the cache refresh work that was done, helped with the env vars processing.

nimakaviani commented 3 years ago

np. thanks for the update.