search

spinnaker / governance

Community documentation for Spinnaker
47 stars 96 forks source link

feat(process): add rfc for backport policy change #303

Closed dogonthehorizon closed 1 year ago

dogonthehorizon commented 1 year ago

Amend the existing backport policy to allow for new features or backwards incompatible changes in behavior provided they are introduced with opt-in feature flags. Details in the RFC.

link108 commented 1 year ago

SGTM! +1

jvz commented 1 year ago

Can we flesh out the feature flag idea a bit? There are libraries like Togglz which provide more sophisticated ways for managing feature flags and configuration for said flags. This general idea, though, sounds good as it's how I've been contributing things so far.

link108 commented 1 year ago

Thank you for calling out the risks!

link108 commented 1 year ago

@jvz happy to wait to merge this for a more fleshed out plan 👍

dogonthehorizon commented 1 year ago

Hey @jvz thanks for the review, I do want to address feature flagging in general but would prefer for it to be out of scope for this policy change. As you say its how we're currently doing contributions, but the larger process for doing so could definitely still use some work. If you're ok with this approach I'd like to merge and follow-up with another RFC just on the feature flag strategy :D

jvz commented 1 year ago

No blockers here. We can break that into a separate RFC.

link108 commented 1 year ago

Thanks all for the reviews! Merging this ✅