search

spinnaker / governance

Community documentation for Spinnaker
47 stars 96 forks source link

RFC: pipeline-builder library #350

Closed nicolasff closed 3 months ago

nicolasff commented 4 months ago

This RFC proposes to add the pipeline-builder Java library to the set of Spinnaker repositories. pipeline-builder helps developers write and maintain pipelines by writing fluent, readable, and testable code as an alternative to the internal JSON format used by Spinnaker.

Links

dbyron-sf commented 3 months ago

We talked at the TOC meeting this morning around the mechanics of this. We could make a separate repo in the spinnaker github org for this, but we were leaning towards waiting for the monorepo. @jcavanagh or @nicolasff curious on your thoughts here.

nicolasff commented 3 months ago

@dbyron-sf Thanks for the review and feedback!

I talked to @jcavanagh today about the monorepo structure since he's currently working on it, and he agreed with the suggestion to move this repo to the spinnaker org before referencing it using a git subtree in the upcoming monorepo.

We already track the pipeline-builder repo in our own monorepo, so Joe will be able to use a similar structure in his current work to integrate this library after its repo is moved to the spinnaker org.

David, let me know when I can transfer ownership. I've looked at the settings in my repo and there doesn't seem to be anything preventing me from transferring it to the spinnaker org. The GitHub docs explain that an email will be sent to the new owner, who needs to approve it within 24 hours or the transfer request will expire. It's ready now, having just been updated with a few commits we had made since it was published.

dbyron-sf commented 3 months ago

@dbyron-sf Thanks for the review and feedback!

I talked to @jcavanagh today about the monorepo structure since he's currently working on it, and he agreed with the suggestion to move this repo to the spinnaker org before referencing it using a git subtree in the upcoming monorepo.

We already track the pipeline-builder repo in our own monorepo, so Joe will be able to use a similar structure in his current work to integrate this library after its repo is moved to the spinnaker org.

David, let me know when I can transfer ownership. I've looked at the settings in my repo and there doesn't seem to be anything preventing me from transferring it to the spinnaker org. The GitHub docs explain that an email will be sent to the new owner, who needs to approve it within 24 hours or the transfer request will expire. It's ready now, having just been updated with a few commits we had made since it was published.

It doesn't sound like we need to do anything in the spinnaker org to prepare for this (e.g. creating a repo), so I say please go ahead and transfer it. Thanks much!

nicolasff commented 3 months ago

@dbyron-sf I am not allowed to transfer the repo directly to the org. Should I try sending it to you instead?

image
dbyron-sf commented 3 months ago

Yeah, if there's some other way to initiate the transfer from your side, please do give it a whirl.

nicolasff commented 3 months ago

Thanks, sent!

image
dbyron-sf commented 3 months ago

Excellent, and I moved it again, so now it's https://github.com/spinnaker/pipeline-builder.