Failed pipeline plan should have a return code of 1

spinnaker / roer

A thin Spinnaker CLI

Apache License 2.0

45 stars 45 forks source link

Open nextrevision opened 6 years ago

nextrevision commented 6 years ago

Whenever a pipeline-template plan fails due to an invalid template the return code is still 0 (see https://github.com/spinnaker/roer/blob/master/actions.go#L234). This makes testing templates in a CI system much harder.

Would be great if we could have a RC of 1

benjaminws commented 6 years ago

If I'm not mistaken, this was fix up by #29.