search

spinnaker / roer

A thin Spinnaker CLI
Apache License 2.0
45 stars 45 forks source link

Pipeline doesn't inherit template's 'Configuration' step artefacts and trigger #49

Closed dstrychalski closed 3 years ago

dstrychalski commented 5 years ago

Pipeline created from a template (both UI or via API) doesn't inherit S3 artefacts and trigger defined in the first 'Configuration' step in the template

karlskewes commented 5 years ago

Does your pipeline app config have something like this defined?

configuration:
  inherit:
    - expectedArtifacts
    - concurrentExecutions
    - triggers
    - parameters

Preceding that section:

---
schema: "1"
pipeline:
  application: exampleapp
  id: exampleapp-deploy-to-dev
  name: deploy-to-dev
  owner: you@example.com
  template:
    source: spinnaker://deploy-to-dev-template
dstrychalski commented 5 years ago

I presume you refer to a pipeline config yaml. When deploying a pipeline with Roer using updated with configuration inherit section pipeline config I get the following error....

DEBU[0000] Reading config file=pipeline-config-test.yml DEBU[0000] getting url url="https://spinnaker-api.../applications/someApp/pipelineConfigs/testing-cofing-inherit" DEBU[0000] Response body= status=200 DEBU[0000] saving pipeline url="https://spinnaker-api..../pipelines" DEBU[0001] Response body="{\"error\":\"Bad Request\",\"exception\":\"com.netflix.spinnaker.gate.controllers.PipelineController$PipelineException\",\"message\":\"failed rendering jinja template\",\"status\":400,\"timestamp\":1538661534706}" status=400 FATA[0001] saving pipeline config: plan request failed

Although through API it works fine when without configuration section. I suspect Orca that needs fixing as after last month Spinnaker update to 1.9.3 I started seeing similar error in Deck (UI) when saving a parametrized pipeline created from a managed template.