spinnaker / spinnaker

Spinnaker is an open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.
http://www.spinnaker.io/
Apache License 2.0
9.32k stars 1.21k forks source link

Deleting application via Spinnaker #205

Closed aglover closed 9 years ago

aglover commented 9 years ago

Submitted by: ruppalapati@netflix.com

From page: http://deck.prod.netflix.net/#/applications

Description: Is it possible to delete an app via Spinnaker? If so how?

anotherchrisberry commented 9 years ago

@aglover what are the restrictions we want in place w/r/t deleting an application? anything? just no server groups?

aglover commented 9 years ago

Is it possible for us to clean up everything associated w/an Application? As in, you confirm deletion, we'll wipe out ASGs, ELBs, security groups, etc?

duftler commented 9 years ago

It would be very cool if when you delete an Application (and all of its bits), it doesn't actually delete it, but instead schedules it for deletion. So maybe it no longer takes traffic, but the actual resources don't get killed off for a day or something.

On Wed Nov 19 2014 at 11:38:14 AM Andrew Glover notifications@github.com wrote:

Is it possible for us to clean up everything associated w/an Application? As in, you confirm deletion, we'll wipe out ASGs, ELBs, security groups, etc?

— Reply to this email directly or view it on GitHub https://github.com/spinnaker/spinnaker/issues/205#issuecomment-63669709.

anotherchrisberry commented 9 years ago

@aglover I'm not sure how much we can do there. We can delete ASGs, and probably delete security groups, and probably ELBs.

It would have to be orca-strated. The current 'delete application' functionality provided by gate simply deletes the record in front50.

anotherchrisberry commented 9 years ago

@duftler I like that idea - especially if we're blowing up the world, maybe disable server groups, then schedule a deletion event in 24 hours.

claymccoy commented 9 years ago

How about we just show the user the things that are keeping us from deleting the app so that they can clean them up. I don't like deleting things en masse that are related to an app.

aglover commented 9 years ago

@claymccoy I think asking a user to delete a bunch of other things is a lot of work -- I like the idea of letting them know what will be deleted and then doing it. When someone actively says delete my app then they shouldn't be surprised that this means that ASGs, etc are going to be blown away. Just like when you delete a repo in Github, it doesn't ask you to 1st delete the branches, etc -- it just warns you that this cannot be undone and asks to you confirm.

aglover commented 9 years ago

@robfletcher What say you regarding Orca-strating this?

aglover commented 9 years ago

ping @robfletcher ^^

aglover commented 9 years ago

ping @robfletcher @danveloper what's LOE here?

danveloper commented 9 years ago

This is done: https://github.com/spinnaker/gate/blob/master/gate-manual/src/asciidoc/deleteApplicationStage.adoc ... Need it surfaced in the UI (https://github.com/spinnaker/deck/issues/129)

aglover commented 9 years ago

Awesome. Thanks.