search

spinnaker / spinnaker

Spinnaker is an open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.
http://www.spinnaker.io/
Apache License 2.0
9.29k stars 1.21k forks source link

Helm hooks are not executing during Spinnaker manifest deployment #5700

Closed sadjunky closed 3 years ago

sadjunky commented 4 years ago

Issue Summary:

Helm hooks are not executing during Spinnaker deploy manifest stage

Cloud Provider(s):

GCP

Environment:

Running Spinnaker using the official Helm chart deployed in Google Kubernetes Engine

Feature Area:

K8S manifest deployment

Description:

During the deployment stage, the job having a pre-upgrade Helm hook should run first, and then the resources should get deployed.

Steps to Reproduce:

Deploy a basic Helm chart along with a Helm hook annotated resource.

Additional Details:

Spinnaker version: 1.19.5 Kubernetes version: 1.15.11-gke5

spinnakerbot commented 4 years ago

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

gdziwoki commented 4 years ago

@spinnakerbot remove-label stale This issue still exists and needs a fix

spinnakerbot commented 4 years ago

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

spinnakerbot commented 4 years ago

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

spinnakerbot commented 3 years ago

This issue is tagged as 'to-be-closed' and hasn't been updated in 45 days, so we are closing it. You can always reopen this issue if needed.

norenstrakh-r7 commented 3 years ago

@spinnakerbot remove-label stale This issue still exists and needs a fix

7onn commented 3 years ago

just faced this issue today 🤔 fortunately i was able to workaround with deployment.spec.template.spec.initContainers

but this only works similar to pre-install or pre-upgrade hooks!

gpouilloux commented 2 years ago

We face this very same issue and will use ìnitContainers` as a workaround although it is not the same as helm hooks.

Are there plans to support Helm hooks in Spinnaker in the future?

jacobleecd commented 1 year ago

Bump - Are there plans to support helm hooks?

ns-mjagtap commented 1 year ago

Bump - We also cannot deploy helm chart of an OSS software using Spinnaker - as it has helm hooks.

Workaround: Do a fresh installation using helm CLI. Thereafter, use Spinnaker for subsequent version upgrades, scale-in/out etc.

oscarbetancurj commented 12 months ago

Will spinnaker be able to deploy helm charts that have hooks? Or this is not even possible?