Support OCI Helm charts

[jackwhelpton]

Issue Summary:

This is basically https://github.com/spinnaker/spinnaker/issues/5915, which was closed owing to age, and which I didn't have permission to reopen.

Helm 3.7.0 makes some changes to the experimental OCI support, deprecating the helm chart command:

https://github.com/helm/helm/pull/9782

[jackwhelpton]

FYI, this is the approach Google are proposing for storing Helm charts in GCP. See:

https://cloud.google.com/artifact-registry/docs/helm

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[jackwhelpton]

@spinnakerbot remove-label stale

[jackwhelpton]

Any feedback on this issue? As we want to move to store our Helm charts in Google Artifact Registry this is a serious blocker for us atm.

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[jackwhelpton]

@spinnakerbot remove-label stale

[jackwhelpton]

Still need this, any updates?

[pandrez]

+1 on this.

Helm 3.8.0 has been released and OCI package distribution is out of Experimental state. Also, Harbor is deprecating ChartMuseum in the near feature (https://github.com/goharbor/harbor/issues/14407) in detriment of OCI packaging, so this feature is getting even more important.

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[deverton]

@spinnakerbot remove-label stale

[deverton]

I had a very quick look at this and one issue will be that Spinnaker is a bit tied to the Helm 2 index.yaml to be able to retrieve the charts. OCI doesn't provide a search mechanism so it's unfortunately not a simple change to support.

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[spinnakerbot]

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

[github-actions[bot]]

This issue hasn't been updated in 45 days so we are tagging it as 'to-be-closed'. It will be closed in 45 days. Add some activity and the label will be removed within several hours.

[ramp23]

@spinnakerbot remove-label stale

[github-actions[bot]]

This issue hasn't been updated in 45 days so we are tagging it as 'to-be-closed'. It will be closed in 45 days. Add some activity and the label will be removed within several hours.

[PJ-ISC]

We'd like to see this being supported as well.

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[monwolf]

We'd like to see this being supported as well. +1

@spinnakerbot remove-label stale

[javierlga]

I don't think closing an issue if there are no updates, a good manner to handle feature requests, bugs, etc… as they can get lost.

I’d also like to be this implemented.

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[rochacon]

@spinnakerbot remove-label stale

[albertocavalcante]

Is there any update?

[albertocavalcante]

Adding another comment to prevent issue go stale

[mattgogerly]

Implementing this is a challenge because the artifact system for container registries caches container images and isn't built to also handle Helm charts.

Perhaps we could get this in by just making the OCI chart reference a text box rather than a fully fledged Spinnaker artifact?

Alternatively we'd likely need to add a helm-oci artifact type.

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[jeanmorais]

@spinnakerbot remove-label stale

[spinnakerbot]

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

[spinnakerbot]

"stale" has not been applied, and cannot be removed.

[willzhang]

So it's maybe why i can't find helm charts in spinnaker UI， it give no results found

mkdir -p /data/registry/auth
 docker run \
  --entrypoint htpasswd \
  httpd:2 -Bbn admin Registry12345 > /data/registry/auth/htpasswd

 docker run -d --name registry \
  --restart=always -p 5000:5000 \
  -v /data/registry/auth:/auth \
  -e "REGISTRY_AUTH=htpasswd" \
  -e "REGISTRY_AUTH_HTPASSWD_REALM=Registry Realm" \
  -e REGISTRY_AUTH_HTPASSWD_PATH=/auth/htpasswd \
  registry:2

helm registry login 192.168.72.16:5000 --insecure -u admin -p Registry12345
helm push --plain-http nginx-15.4.3.tgz oci://192.168.72.16:5000/helm-charts/nginx

hal config artifact helm enable

hal config artifact helm account add registry-helm-account \
--repository http://192.168.72.16:5000/helm-charts \
--username admin \
--password Registry12345

hal deploy apply

Is it related to the issue，helm currently does not support searching for OCI helm charts：https://github.com/helm/helm/issues/11000

[BojanZelic-DD]

argocd was able to workaround the listing/searching behavior by doing this: https://github.com/argoproj/argo-cd/pull/10641