Problem extracting image names when baking in GCP

Issue Summary:

Currently, Rosco obtains the image name by scrapping the logs for a certain string:

“googlecompute: A disk image was created:”

Here are the code portions responsible for this task:

However, starting in version v1.1.2 of the packer’s "googlecompute" plugin, they have changed the string representation of the artifact to be as follows:

"A disk image was created in the '%v' project: %v"

Here is how it looks in v1.1.2 and later, and here is how it looks in v1.1.1 and previous.

Even though this does not affect the baking, as Spinnaker can create and push the images to GCP, any posterior deployment stage fails as the image name cannot be extracted, because the string filtering no longer matches.

I believe this bug can be fixed simply by removing the colon at the end of the string in this line, e.g. like this:

private static final String IMAGE_NAME_TOKEN = "googlecompute: A disk image was created"

This should cause a match for both cases, although I'm not fully familiarized with the code to know if the proposed fix can have an impact in other section.

Cloud Provider(s):

GCP

Environment:

Previously, we were running version 1.26.5, and this was not an issue as the embedded packer version was not using plugins (1.6.x), but recently updated to the latest stable version (1.35.4), which is when we started experiencing this problem.

Feature Area:

Image Baking (Rosco).

Steps to Reproduce:

Create a pipeline that Bakes an image and then deploys it in GCP, using Spinnaker v1.35.4 (but potentially more previous versions).

Additional Details:

Error reflected in the UI:

Error

Here is a portion of the Json logs extracted from the UI for a failed execution:

{
  "application": "backend",
  "authentication": {
    "allowedAccounts": [],
    "user": "user@domain.com"
  },
  "buildTime": 1726862150874,
  "canceled": false,
  "endTime": 1726862694557,
  "id": "01J88G2K3W50B5685SEPX9AKCT",
  "initialConfig": {

  },
  "keepWaitingPipelines": false,
  "limitConcurrent": true,
  "maxConcurrentExecutions": 0,
  "name": "backend-security",
  "notifications": [],
  "origin": "api",
  "pipelineConfigId": "4b71cbb0-9480-4f93-9636-059d4bb80e83",
  "stages": [
    {
      "context": {
        "amiSuffix": "20240920195551",
        "artifacts": [
          {
            "customKind": false,
            "location": "global",
            "metadata": {

            },
            "name": "backend-security-all-20240920195551-xenial",
            "reference": "https://compute.googleapis.com/compute/v1/projects/[account]/global/images/null",
            "type": "gce/image",
            "uuid": "65f1dbfd-6661-43d6-9eb9-faefb4b143a3"
          }
        ],
        "bakePackageName": "backend-security",
        "baseLabel": "release",
        "baseOs": "xenial",
        "cloudProvider": "gce",
        "cloudProviderType": "gce",
        "extendedAttributes": {
          "node-role": "backend-security"
        },
        "name": "Bake in global",
        "package": "backend-security",
    …

And here is the equivalent log for a pre-update (v1.26.5) execution:

{
  "application": "backend",
  "authentication": {
    "allowedAccounts": [],
    "user": "user@domain.com"
  },
  "buildTime": 1726844779122,
  "canceled": false,
  "endTime": 1726844899957,
  "id": "01J87ZGEFAH1RG11A5ECKXR4Q6",
  "initialConfig": {

  },
  "keepWaitingPipelines": false,
  "limitConcurrent": true,
  "maxConcurrentExecutions": 0,
  "name": "backend-security",
  "notifications": [],
  "origin": "api",
  "pipelineConfigId": "4b71cbb0-9480-4f93-9636-059d4bb80e83",
  "stages": [
    {
      "context": {
        "ami": "backend-security-2024-07-12t13-25-52z",
        "amiSuffix": "20240920150619",
        "artifacts": [
          {
            "customKind": false,
            "location": "global",
            "metadata": {

            },
            "name": "backend-security-all-20240712132551-xenial",
            "reference": "https://compute.googleapis.com/compute/v1/projects/[account]/global/images/backend-security-2024-07-12t13-25-52z",
            "type": "gce/image",
            "uuid": "58a0a223-bc04-41b0-8078-a387b9cb541b"
          }
        ],
        "bakePackageName": "backend-security",
        "baseLabel": "release",
        "baseOs": "xenial",
        "cloudProvider": "gce",
        "cloudProviderType": "gce",
        "extendedAttributes": {
          "node-role": "backend-security"
        },
        "imageId": "backend-security-2024-07-12t13-25-52z",
        "imageName": "backend-security-2024-07-12t13-25-52z",
        "name": "Bake in global",
        "package": "backend-security",
    …

You can see in the failed execution, stages.context.artifacts.reference has a "null" reference, also the fields: stages.context.artifacts[ami, imageId, imageName] are not populated.

spinnaker / spinnaker