fix document.body.scrollTop issue in Firefox

spinningarrow / zoom-vanilla.js

Medium's image zoom in vanilla JS (no jQuery).

https://code.sahil.me/zoom-vanilla.js/

MIT License

234 stars 22 forks source link

fix document.body.scrollTop issue in Firefox #25

Closed collnwalkr closed 7 years ago

heavybeard commented 8 years ago

Hi @collnwalkr, very good work! It is an excellent analysis.

It work to me on (I'm on Windows 10 PC 1920x1080):

Microsoft Edge 38.14393.0.0
Google Chrome 53.0.2785.143 m (64-bit)
Mozilla Firefox 49.0.1
Opera 40.0.2308.81
Safari 5.1.7

On IE 11 there's some issues, but your PR fix them in part ('ll open a new issue). I can't provide a video right now, but this PR works very well. @spinningarrow what do you think about it?

spinningarrow commented 7 years ago

Great work! Thanks a lot.

I've merged this; unfortunately GitHub got confused.