search

spinsphotonics / fdtdz

Fast, scalable, accessible photonic simulation
MIT License
110 stars 13 forks source link

Incorrect dipole test output? #24

Closed smhooten closed 9 months ago

smhooten commented 9 months ago

Hello, thanks for sharing this nice project. I wonder if there is an issue with the dipole test case on the Colab notebook, or if I need to adjust some settings? I am seeing the output below. I got the same output in my local installation of fdtd-z. image

jlu-spins commented 9 months ago

Hi Sean! Sorry about the slow reply. You're seeing reflections from the PML in your dipole output. The PML coefficients can be tuned to work better, but I think there is some bug with the current implementation unfortunately, created an issue at https://github.com/spinsphotonics/fdtdz/issues/19

On Wed, Nov 29, 2023 at 5:12 PM smhooten @.***> wrote:

Hello, thanks for sharing this nice project. I wonder if there is an issue with the dipole test case on the Colab notebook, or if I need to adjust some settings? I am seeing the output below. I got the same output in my local installation of fdtd-z. image.png (view on web) https://github.com/spinsphotonics/fdtdz/assets/43480548/9101201d-26c8-4311-aa59-b28b859aeb18

— Reply to this email directly, view it on GitHub https://github.com/spinsphotonics/fdtdz/issues/24, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3VGPQJMXFWXKYZ3OIINMITYG7MRLAVCNFSM6AAAAABAAMDUZKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTONRZGEZDAOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

smhooten commented 9 months ago

Got it, thanks Jesse. I'll play around with the settings myself. I will close the issue for the time being since it is already known.