spinsphotonics / fdtdz

Fast, scalable, accessible photonic simulation
MIT License
114 stars 13 forks source link

example notebook on colab: difference in output between reduced precision and full precision #25

Open flaport opened 11 months ago

flaport commented 11 months ago

Hi, when running the colab notebook with reduced precision, I'm getting the following plot:

image

However, when running with full precision (use_reduced_precision=False), I'm getting this plot:

image

notice the small excitation in the top left corner.

I suppose this is a bug? Maybe an issue with the PML?

jlu-spins commented 11 months ago

Yes this is a bug, see https://github.com/spinsphotonics/fdtdz/issues/20

On Sat, Dec 2, 2023 at 6:39 PM Floris Laporte @.***> wrote:

Hi, when running the colab notebook with reduced precision, I'm getting the following plot:

image.png (view on web) https://github.com/spinsphotonics/fdtdz/assets/15832886/f3e0ad13-59e6-44af-974d-36041648ab57

However, when running with full precision (use_reduced_precision=False), I'm getting this plot:

image.png (view on web) https://github.com/spinsphotonics/fdtdz/assets/15832886/a5ce52a6-adca-488c-9dbc-16cedc9d704b

notice the small excitation in the top left corner.

I suppose this is a bug? Maybe an issue with the PML?

— Reply to this email directly, view it on GitHub https://github.com/spinsphotonics/fdtdz/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3VGPQMIZEZZ5A5ZSURFNQDYHPQ55AVCNFSM6AAAAABAEOG6WSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDEMRZHEZDKNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>