search

spion / adbfs-rootless

Mount Android phones on Linux with adb. No root required.
Other
908 stars 73 forks source link

Root is not required to unmount #26

Closed Lonami closed 6 years ago

Lonami commented 6 years ago

This application claims to be rootless, yet it suggests to use sudo umount in the README which needs root access :P

I haven't tried (but have plans to use) this yet, but I think using fusermount -u <dir> should work. Just in case anyone finds this information useful.

Edit: Yep, not required, just tested.

spion commented 6 years ago

Rootless in this context means you don't have to "root" your phone.

Lonami commented 6 years ago

I know, I know. I'm just stating that you don't even need root in a normal desktop environment to unmount it, since you can use fusermount -u <dir> as a normal user. I thought the title was clear enough.

Aire-One commented 6 years ago

If I correctly recall, you don't even need root permission (for mount and umount (desktop side)) with correct rights as a regular user on the mount point...

The problem here is that not everyone can/want to root his Android device. This repo aims to provide rootless Android side access to the Android device filesystem. The desktop side entirely depends on your local configurations and the way you manage your users rights.

That said, I'm agreeing with @Lonami. Because adbfs works with FUSE, fusermount -u should be used in the README instead of umount. At least, it should be mention as an option.

spion commented 6 years ago

Allrighty then. PR welcome :rabbit:

spion commented 6 years ago

This is all good now I think - closing, but feel free to shout if there are troubles.