search

spion / triplie-ng

Chatbot with Markov chains BFS and Hebbian learning
MIT License
57 stars 16 forks source link

Context words are using an undefined date #33

Open Kermalis opened 3 years ago

Kermalis commented 3 years ago

Here, the now date should be passed in as a second parameter: https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160 You can see that the ts param is never being given a value https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160

So context is completely broken.

Side not unrelated to this issue, you are fetching keywords(words) three times, resulting in massive overhead: https://github.com/spion/triplie-ng/blob/master/lib/pipeline/associate.js#L160 My C# port is working incredibly faster from just passing keys instead of fetching the 2nd and 3rd time.