spiral-modules / roadrunner-binary

πŸ’Ύ High-performance PHP application server, load-balancer and process manager written in Golang. RR2 releases repository.
MIT License
44 stars 25 forks source link

fix(config): wrong port values #124

Closed b-viguier closed 2 years ago

b-viguier commented 2 years ago

Reason for This PR

When executing rr with provided file, we got following error:

* cannot parse 'ssl.acme.alt_http_port' as int: strconv.ParseInt: parsing "80,": invalid syntax
* cannot parse 'ssl.acme.alt_tlsalpn_port' as int: strconv.ParseInt: parsing "443,": invalid syntax

Description of Changes

Removal of the misleading ,

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

Misc.

Thank you for your work πŸ˜„

codecov[bot] commented 2 years ago

Codecov Report

Merging #124 (c8f33c8) into master (c282abe) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   43.59%   43.59%           
=======================================
  Files          12       12           
  Lines         562      562           
=======================================
  Hits          245      245           
  Misses        306      306           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 1342a90...c8f33c8. Read the comment docs.