spiral-modules / roadrunner-binary

💾 High-performance PHP application server, load-balancer and process manager written in Golang. RR2 releases repository.

MIT License

44 stars 25 forks source link

refactor(app): Deep application refactoring #24

Closed tarampampam closed 3 years ago

tarampampam commented 3 years ago

Reason for This PR

The current implementation contains the following approaches that can be improved:

A lot of init() function usage
Wide variables scope ("global" vars)
Mixed areas of responsibility code sections
Does not follows golang-standards/project-layout recomendations
A lot of panic() and log.Fatal() calling
Hard to test

Description of Changes

Each sub-command now located in separate package
No one panic() or log.Fatal() calling
Each variable has own (minimalistic) scope
Code parts can be tested independently of each other
Dotenv support now located in root CLI command (not in main.go)
Following golang-standards/project-layout recomendations
Strong golangci-lint config added
Unit tests running using CI
Dockerfile does not includes go mod download for performance reasons (we should not to download dependencies for a unit testing)
build CI step renamed into tests
README.md badges fixed

Open questions (PR TODO list)

[x] Should we test the build on version 1.15?
[x] Write more unit-tests (TODO)
[x] Resolve all TODO/FIXME in code
[x] We need to create page on codecov (reason)

:warning: Inportant note for reviewer

Please, checkout on this branch locally, and review changes in your IDE.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.] [Reviewer TODO: Verify that these criteria are met. Request changes if not]

[x] All commits in this PR are signed (git commit -s).
[ ] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@eab60f3). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage          ?   52.38%           
=========================================
  Files             ?       11           
  Lines             ?      294           
  Branches          ?        0           
=========================================
  Hits              ?      154           
  Misses            ?      130           
  Partials          ?       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eab60f3...deef021. Read the comment docs.