spiral-modules / roadrunner-binary

💾 High-performance PHP application server, load-balancer and process manager written in Golang. RR2 releases repository.

MIT License

44 stars 25 forks source link

fix(config): Server env map #53

Closed tarampampam closed 3 years ago

tarampampam commented 3 years ago

Reason for This PR

Fixing server env variables map.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.] [Reviewer TODO: Verify that these criteria are met. Request changes if not]

[x] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (fc6d2d0) into master (ca57bd9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   50.66%   50.66%           
=======================================
  Files          11       11           
  Lines         300      300           
=======================================
  Hits          152      152           
  Misses        137      137           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca57bd9...fc6d2d0. Read the comment docs.

tarampampam commented 3 years ago

Corba converts env names to lower case when:

server:
  env:
    SOME_KEY: "SOME_VALUE"
    SOME_KEY2: "SOME_VALUE2"