spiral-modules / roadrunner-binary

💾 High-performance PHP application server, load-balancer and process manager written in Golang. RR2 releases repository.
MIT License
44 stars 25 forks source link

fix(container): do not call the container's Stop method after the container is stopped by an error #81

Closed rustatian closed 3 years ago

rustatian commented 3 years ago

Reason for This PR

Description of Changes

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.] [Reviewer TODO: Verify that these criteria are met. Request changes if not]

codecov[bot] commented 3 years ago

Codecov Report

Merging #81 (bada819) into master (c32c289) will increase coverage by 0.24%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   44.44%   44.69%   +0.24%     
==========================================
  Files          12       12              
  Lines         360      358       -2     
==========================================
  Hits          160      160              
+ Misses        189      187       -2     
  Partials       11       11              
Impacted Files Coverage Δ
internal/cli/serve/command.go 9.75% <100.00%> (+0.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c32c289...bada819. Read the comment docs.