spiral-modules / roadrunner-binary

💾 High-performance PHP application server, load-balancer and process manager written in Golang. RR2 releases repository.
MIT License
44 stars 25 forks source link

[BUG] Release `2.3.2` made installation process crash #83

Closed senorihl closed 3 years ago

senorihl commented 3 years ago

I tried this code:

rr -vvv get

I expected to have binaries installed

Instead, this happened: Invalid version string "v2.3.2 [MISSING ENTRY IN THE go.mod]"

Which is available here https://github.com/spiral/roadrunner-binary/releases/tag/v2.3.2.

The version of RR used: 2.3.2

The operation system used: Dockerized Ubuntu 20.04

RR configuration file content: N/A

Errortrace, Backtrace or Panictrace:

 Environment:
   - Version:          2.3.3
   - Stability:        stable
   - Operating System: linux
   - Architecture:     amd64

In VersionParser.php line 185:

  [UnexpectedValueException]
  Invalid version string "v2.3.2 [MISSING ENTRY IN THE go.mod]"

Exception trace:
  at /usr/local/.composer/vendor/composer/semver/src/VersionParser.php:185
 Composer\Semver\VersionParser->normalize() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/Release.php:78
 Spiral\RoadRunner\Console\Repository\Release->parseVersion() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/Release.php:59
 Spiral\RoadRunner\Console\Repository\Release->__construct() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/GitHub/GitHubRelease.php:43
 Spiral\RoadRunner\Console\Repository\GitHub\GitHubRelease->__construct() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/GitHub/GitHubRelease.php:81
 Spiral\RoadRunner\Console\Repository\GitHub\GitHubRelease::fromApiResponse() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/GitHub/GitHubRepository.php:85
 Spiral\RoadRunner\Console\Repository\GitHub\GitHubRepository->Spiral\RoadRunner\Console\Repository\GitHub\{closure}() at n/a:n/a
 iterator_to_array() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/Collection.php:48
 Spiral\RoadRunner\Console\Repository\Collection::create() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/Collection.php:69
 Spiral\RoadRunner\Console\Repository\Collection::from() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/GitHub/GitHubRepository.php:88
 Spiral\RoadRunner\Console\Repository\GitHub\GitHubRepository->getReleases() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/RepositoriesCollection.php:44
 Spiral\RoadRunner\Console\Repository\RepositoriesCollection->Spiral\RoadRunner\Console\Repository\{closure}() at n/a:n/a
 iterator_to_array() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/Collection.php:48
 Spiral\RoadRunner\Console\Repository\Collection::create() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/Collection.php:69
 Spiral\RoadRunner\Console\Repository\Collection::from() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Repository/RepositoriesCollection.php:46
 Spiral\RoadRunner\Console\Repository\RepositoriesCollection->getReleases() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/Command/VersionFilterOption.php:75
 Spiral\RoadRunner\Console\Command\VersionFilterOption->find() at /usr/local/.composer/vendor/spiral/roadrunner-cli/src/GetBinaryCommand.php:107
 Spiral\RoadRunner\Console\GetBinaryCommand->execute() at /usr/local/.composer/vendor/symfony/console/Command/Command.php:299
 Symfony\Component\Console\Command\Command->run() at /usr/local/.composer/vendor/symfony/console/Application.php:978
 Symfony\Component\Console\Application->doRunCommand() at /usr/local/.composer/vendor/symfony/console/Application.php:295
 Symfony\Component\Console\Application->doRun() at /usr/local/.composer/vendor/symfony/console/Application.php:167
 Symfony\Component\Console\Application->run() at /usr/local/.composer/vendor/bin/rr(21) : eval()'d code:71
 eval() at /usr/local/.composer/vendor/bin/rr:21

I suggest you edit release title

rustatian commented 3 years ago

Hey @senorihl . Do not use 2.3.2. You 2.3.3 instead. In 2.3.2 release missed go.mod dependency. Sorry for the inconvenience. Edit: I have removed the comment from v2.3.2. tag.

senorihl commented 3 years ago

Awesome 👍

Thank you