spiral-project / daybed

Form validation and data storage API
http://daybed.rtfd.org/
BSD 3-Clause "New" or "Revised" License
53 stars 8 forks source link

Hawk review concepts #203

Closed leplatrem closed 10 years ago

leplatrem commented 10 years ago

For this pull request, its author has lost 12 points of energy.

Natim commented 10 years ago

Please don't change the Token -> Identifier wording. The aims is to keep Daybed simple by just handling secure tokens generated on server side.

If you change to identifier people can decide to use an email identifier with a password secret instead of tokens and we should enforce this will not happen for security reason and simplicity.

Also we will use sessionToken directly in the URL for some HTML5 apps (like the Todo one) so I wanted change get_token(tokenId) to return the sessionToken rather than only the authKey so we can then always return the sessionToken on the oauth endpoint.

almet commented 10 years ago

Not valid anymore, closing.