search

spiral-project / daybed

Form validation and data storage API
http://daybed.rtfd.org/
BSD 3-Clause "New" or "Revised" License
53 stars 8 forks source link

Accept an extra property to models definition to put other model related informations. #249

Closed Natim closed 9 years ago

Natim commented 9 years ago

Fix the Formbuilder error with submitButtonLabel

leplatrem commented 9 years ago

What do you think of a single optional attribute like extra, instead of allowing to store anything possible ?

Natim commented 9 years ago

Well what is the difference?

leplatrem commented 9 years ago

Well, it would keep models definitions tidy.

Plus I guess that validating an object with 4096 properties is a lot more costly than validating an object with 5 :)

Natim commented 9 years ago

I've added some documentation about the new extra fields.

leplatrem commented 9 years ago

Thanks for taking care of me and my narrow-minded feedbacks :)

Natim commented 9 years ago

@leplatrem Your are more than welcome, I like it :+1:

leplatrem commented 9 years ago

LGTM! You can merge when Travis approves ;)

almet commented 9 years ago

thanks :)