search

spiral-project / daybed

Form validation and data storage API
http://daybed.rtfd.org/
BSD 3-Clause "New" or "Revised" License
53 stars 8 forks source link

Improve the ElasticSearch cluster configuration to allow basic_auth ES access #267

Open Natim opened 9 years ago

Natim commented 9 years ago

Updated.

leplatrem commented 9 years ago

I'm not against merging this, but a bit doubtful though.

We can have all this code in Daybed, but in the mean time, opening a PR on elasticsearch-py would be worth it IHMO. I don't see why it shouldn't support absolute urls for hosts!

Natim commented 9 years ago

Why should it?

leplatrem commented 9 years ago

The dict formalism is rather curious, since there's a standard for that! RFC-1738 :)

Natim commented 9 years ago

I can make a pull-request to them based on this assumption. There is not urgency yet to merge this patch since I already applied it in production.

leplatrem commented 9 years ago

Ok.

Also, I wouldn't have created a dedicated module just for one utility function. But it may be a matter of taste :) More generally, we should start thinking of #213 :)

Natim commented 9 years ago

More generally, we should start thinking of #213 :)

Exactly the reason why I did it like so :)

Natim commented 9 years ago

Here we go: https://github.com/elasticsearch/elasticsearch-py/pull/149

leplatrem commented 9 years ago

Good job @Natim! Your PR was merged in ES python client :) We will soon be able to close this here!