search

spiral-project / ihatemoney

A simple shared budget manager web application
https://ihatemoney.org
Other
1.18k stars 267 forks source link

Documentation no longer updates automatically #1185

Closed zorun closed 5 months ago

zorun commented 1 year ago

It says "Failed" on https://readthedocs.org/projects/ihatemoney/builds/

This happened before in #653

Maybe we should update documentation from the Github CI, so that we would be aware when it breaks.

zorun commented 1 year ago

Still not working, different issue: https://readthedocs.org/projects/ihatemoney/builds/21301509/

@Glandos apparently the sphinx-rtd-theme from readthedocs does not support Sphinx 7:

I see you updated Sphinx #1172 because of docutils, why do we need a newer docutils?

zorun commented 1 year ago

To be honest (it's definitely not against you @Glandos ), I'm really fed up with dependabot trying to update everything to the latest version, even if we don't actually need it... (e.g. not for security issues)

But maybe that's just me being conservative :D

Glandos commented 1 year ago

I think I should also refrain from clicking on "Update" each time I am notified of something just to have a dopamine shot.

I think that:

For this specific issue, I am bit hesitant. We can downgrade Sphinx/docutils after all, it won't impact any users. It seems that waiting for a new release of sphinx_rtd_theme is like waiting for the rain in the hot summer of Spain: it will happen, you don't know when.

zorun commented 1 year ago

Totally agree on saving our time, we don't have enough to spend on tedious/pointless fixes :)

If updating sphinx and docutils has no added value, I'm all for downgrading to older versions that work with readthedocs. After all, that's why we pin versions.

almet commented 1 year ago

Hi folks! I agree with you both on that. Regarding the autoupdate of readthedocs. It used to be configured directly on readthedocs, with a hook that happened when we tagged a new version.

It's been a while, so maybe it's not working anymore, though. Maybe nowadays it's better to use the CI for this? Not sure, do you do this on others projects?

zorun commented 1 year ago

@Glandos do you have time to downgrade Sphinx to fix this issue?