spiral-project / ihatemoney

A simple shared budget manager web application
https://ihatemoney.org
Other
1.18k stars 267 forks source link

Currency hotfixes #1240

Closed zorun closed 1 year ago

zorun commented 1 year ago

Hardcode list of currencies, and temporarily disable some currency operations to prevent crashes.

Here is what is disabled:

Adjust and skip tests as necessary.

The real fix will come after #1232 is discussed

zorun commented 1 year ago

I'd like to release version 6.1.1 as soon as this is merged (which means really soon)

zorun commented 1 year ago

You mean simulating the exception that would be raised by the API call? It's a good idea, that would have allowed us to catch this way earlier. But I'm not motivated enough to do this now...

almet commented 1 year ago

You mean simulating the exception that would be raised by the API call? It's a good idea, that would have allowed us to catch this way earlier. But I'm not motivated enough to do this now...

I understand, especially as it's a quick fix for an emergency release. Let's move on then, I won't have the time to add it either.

Thanks again for doing that!

zorun commented 1 year ago

Thanks for the review! I will make the release now.