spiral-project / ihatemoney

A simple shared budget manager web application
https://ihatemoney.org
Other
1.18k stars 267 forks source link

Migrate from setup.cfg to pyproject.toml #1243

Closed azmeuk closed 12 months ago

azmeuk commented 12 months ago

I was having a look at #1238 and I realized that setuptools+setup.cfg is not really convenient for build callbacks (such as: catalog compilation). I was thinking about using hatch instead of setuptools to build packages, like we did recently in wtforms, as it is lightweight and provides build callbacks, and setuptools is deprecated anyways (since it is built on distutils, that have just been deleted in python 3.12).

Anyways, if we use hatch in the future (or flit, or poetry, or whatever), then pyproject.toml is required, and if we keep using setuptools, pyproject.toml won't harm :)

We can have the discussion about the build tool on #1238

zorun commented 12 months ago

Thanks for the work @azmeuk

@almet Could you please let time for other people to review changes before merging them extra-fast? In that case, I would have like to:

almet commented 12 months ago

@zorun I'm sorry I didn't let you more time to review this. I understand what you mean and why it could have been simpler to merge it later on.

I believe these scenarii will probably happen more often than before, as more people are working on the repository than usual. We might want to setup some rules for merging, releasing, etc.

I see different ways to solve this, I've open #1245 to discuss that.