search

spiral-project / ihatemoney

A simple shared budget manager web application
https://ihatemoney.org
Other
1.18k stars 267 forks source link

fix: Add NOT NULL to many fields #143 (Ademola111) #1268

Open Ademola111 opened 10 months ago

Ademola111 commented 10 months ago

I have added the NOT NULL fields and i would like to have it reviewed. more so i will be glad to join the community to contribute more. Warm regards.

zorun commented 10 months ago

Hi, can you explain the reasoning behind this change?

Ademola111 commented 10 months ago

Reading from the issue question I got to know that you wasn’t the database to be secured by adding nullable=True to all tables in the database so I pick it up to contribute as part of my open source.

Thank you.

On Thu, 23 Nov 2023 at 23:10, zorun @.***> wrote:

Hi, can you explain the reasoning behind this change?

— Reply to this email directly, view it on GitHub https://github.com/spiral-project/ihatemoney/pull/1268#issuecomment-1824960321, or unsubscribe https://github.com/notifications/unsubscribe-auth/APB5FCF45Y5NWR7GPYIIHQ3YF7CVRAVCNFSM6AAAAAA7R3QE2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUHE3DAMZSGE . You are receiving this because you authored the thread.Message ID: @.***>