search

spiral-project / ihatemoney

A simple shared budget manager web application
https://ihatemoney.org
Other
1.18k stars 267 forks source link

New Feature Implementation: Division by join / leave time and bill period #1277

Closed NicoleeeTian closed 5 months ago

NicoleeeTian commented 10 months ago

Hello Ihatemoney Project Contributors,

We hope this message finds you well. Our group has been actively addressing issues posted in this GitHub issue and we're excited to share our progress.

In our implementation, we recognized the necessity of introducing a new feature: a bill period, complete with its starting date and end date. Additionally, there's a crucial modification to the database structure. For every active member involved in a bill, we now require corresponding start and end dates to be specified for each person (this changed is in billowers). This enhancement allows for a more detailed representation of members' involvement periods.

In addressing concerns related to distribution fairness, we've also revamped the bill-splitting function. The new implementation takes into account each individual's contributing time, ensuring a fair distribution of expenses.

We appreciate your time and collaboration in reviewing our proposed changes. Please find our pull request for your consideration. We are open to feedback and eager to work together to enhance the Ihatemoney project.

Thank you for your ongoing dedication to the Ihatemoney community.

almet commented 10 months ago

Hi, thanks for opening this. The number of files in the PR doesn't seem right though.

I'm also not sure having a start and end date is the way to go, as mentioned in earlier discussions having a way to weight each participant could be easier to understand for the users.

Let me know when it's in a reviewable state.

zorun commented 5 months ago

We decided not to accept #1228 because it does not fit the current direction of the project. As a result, we are also closing this pull request.

We would like to still thank you for your contribution, and we hope that it won't discourage you to contribute to open source projects in the future.

wargreen commented 5 months ago

Thanks for the attempt, and for all the thinking time.

Maybe can this be inclued in the Cospend app for nextcloud ? It seem to be lot of feature and some are complex !