spiral-project / ihatemoney

A simple shared budget manager web application
https://ihatemoney.org
Other
1.2k stars 270 forks source link

Different behaviors while directly visit project URLs #1284

Open nevercodecorrect opened 10 months ago

nevercodecorrect commented 10 months ago

Hello, An attacker could know what are the projects exist by simply brute-force checking localhost:8080/testproject. If the returned page is authenticator then he knows the project exist as if the project does not exist, the returned page will be create project page. It also applies to the user/bill index. The returned page are different and the index is easy to guess. All those trials does need any login/priveledge at all.

almet commented 10 months ago

You're correct, thanks for bringing this up. I believe it's a tradeoff we're doing right now, to ease the life of the users.

Some more context:

Mitigations:

What do you think?

almet commented 7 months ago

We want to display the authentication page in all cases, and ideally merge the project creation form with the one from the homepage.

nevercodecorrect commented 6 months ago

Sorry for the late reply, that would be better in term of security,