Closed TomRoussel closed 7 months ago
Thanks, it all looks good! Indeed, I overlooked the test checking the new endpoint.
FYI, we should also convert this new endpoint to POST to avoid XSS issues, but let's move that to another thread (I have started doing the conversion)
This PR contains the changes requested after PR #1290 was merged. It contains only pretty minor changes. Specifically this PR contains the following:
web.settle
route contained a "FIXME" comment. Looking into it, I think it was previously erroneously copied fromedit_bill
in web.py:811. It doesn't need to check if the bill belongs to the requested project as this function creates that bill itself.web.settle
route, however this route is already being tested inbudget_test.py:1309
,test_settle_button
. In this test, the settle route is called and checked. So no new test was added.@zorun, I think that was everything you asked back in #1290? Let me know if there is anything I missed!