search

spiral-software / fftx

FFTX Project
Other
19 stars 12 forks source link

changes for larger sized distributed FFTs #201

Closed elliottbinder closed 11 months ago

elliottbinder commented 11 months ago

Functionally different changes here upcast int sizes to larger width integers in order to not overflow when the product of the 3D sizes exceeds what can fit in standard int sizes. Also some formatting changes. Moved FORCE_VENDOR_LIB macro to a shared header to be used by both 1D and 2D distributed.

elliottbinder commented 11 months ago

I changed the default value for the FORCE_VENDOR_LIB macro to enable Spiral code. Sorry, I thought that I had done that before.

I tried running the test above but I'm getting what looks like some runtime errors. I'll look into it.

elliottbinder commented 11 months ago

We tested RTC without the distributed test routine and got the same error:

ebinder@login2:~/software/fftx_nov1/fftx/build> ./examples/mddft/testmddft 24 32 40 allocating memory

main error: hipErrorNotSupported failed with error operation not supported

We tested distributed with the vendor library successfully. It looks like there might be an issue elsewhere.

broderickpt commented 11 months ago

Compiled and built on both crusher & frontier. Correctly ran tests (see script above) for all sizes on both systems.