search

spiral / cycle-bridge

🌉 Cycle ORM v2 bridge to Spiral Framework
https://cycle-orm.dev
MIT License
16 stars 6 forks source link

Fixing property types in EntityDeclaration #45

Closed msmakouz closed 2 years ago

msmakouz commented 2 years ago
roxblnfk commented 2 years ago

What about failed tests?

msmakouz commented 2 years ago

What about failed tests?

Failed tests related to PR in SF: https://github.com/spiral/framework/pull/747

And wait for a new release here: https://github.com/spiral/validator

codecov[bot] commented 2 years ago

Codecov Report

Merging #45 (b52540d) into 2.0 (b6b3dc1) will increase coverage by 4.05%. The diff coverage is 88.88%.

@@             Coverage Diff              @@
##                2.0      #45      +/-   ##
============================================
+ Coverage     71.95%   76.00%   +4.05%     
- Complexity      377      382       +5     
============================================
  Files            46       46              
  Lines          1002     1017      +15     
============================================
+ Hits            721      773      +52     
+ Misses          281      244      -37
Impacted Files Coverage Δ
...affolder/Declaration/AbstractEntityDeclaration.php 65.11% <75.00%> (+65.11%) :arrow_up:
src/Auth/Token.php 92.59% <100.00%> (+6.87%) :arrow_up:
src/Bootloader/CycleOrmBootloader.php 100.00% <100.00%> (ø)
...folder/Declaration/Entity/AnnotatedDeclaration.php 39.47% <0.00%> (+39.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cd27d9...b52540d. Read the comment docs.