search

spiral / framework

High-Performance PHP Framework
https://spiral.dev
MIT License
1.8k stars 87 forks source link

Handle cases where job handler class does not exist or just a string in `RetryPolicyInterceptor` #1025

Closed butschster closed 9 months ago

butschster commented 10 months ago

Additionally, made modifications to getRetryPolicy to ensure it returns null when the handler is not a class. This improves error handling and eliminates the risk of encountering runtime errors due to attempted operations on non-existent classes. Corresponding unit tests have been added.

Q A
Bugfix? ✔️
Breaks BC? ❌

This PR is a blocker for https://github.com/spiral/roadrunner-bridge/pull/81

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a67a187) 89.22% compared to head (3434a31) 89.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1025 +/- ## ========================================= Coverage 89.22% 89.23% - Complexity 6192 6194 +2 ========================================= Files 816 816 Lines 17453 17456 +3 ========================================= + Hits 15573 15576 +3 Misses 1880 1880 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.