spiral / framework

High-Performance PHP Framework
https://spiral.dev
MIT License
1.82k stars 89 forks source link

[spiral/router] Update Route list command for customization route class #1070

Closed iAvenger01 closed 10 months ago

iAvenger01 commented 10 months ago

Changing the use of an implementation to an interface to implement a custom route

Q A
Bugfix?
Breaks BC? ✔️
New feature?

I have my own custom route class that inherits from RouteInterface just like the original class from the spiral/router package. However, the command to display routes does not work because it uses an implementation class rather than an interface in the types. This PR is acknowledged to correct this.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3db2bb2) 89.51% compared to head (295620c) 89.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1070 +/- ## ============================================ - Coverage 89.51% 89.50% -0.01% Complexity 6316 6316 ============================================ Files 824 824 Lines 17799 17799 ============================================ - Hits 15932 15931 -1 - Misses 1867 1868 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.