search

spiral / framework

High-Performance PHP Framework
https://spiral.dev
MIT License
1.82k stars 89 forks source link

Fix @template-covariant usage on Target and TargetInterface #1164

Closed samsonasik closed 1 week ago

samsonasik commented 1 week ago
Q A
QA? ✔️

The definition is already nullable

@template-covariant TController of object|null

so add TController|null on @param and @return should be updated to TController only.

Then RemoveUselessParamTagRector and RemoveUselessReturnTagRector skip can be cleaned up.

samsonasik commented 1 week ago

Ready to merge 👍