spiral / roadrunner-bridge

🌉 RoadRunner bridge to Spiral Framework
https://spiral.dev/docs/packages-roadrunner-bridge
MIT License
12 stars 6 forks source link

Calling disconnect on a Centrifugo request throws exception #100

Open arizanovj opened 5 months ago

arizanovj commented 5 months ago

Description

There is no possibility to open issues on the related repo, so I'm doing it here instead.

When I try to call disconnect in my Auth interceptor for proxied centrifugo connections an error is thrown because of a missing field in one of the DTOs.

Exception & stacktrace:

{
    "exception": {
      "error": "[Exception] No such field reconnect as /vendor/roadrunner-php/roadrunner-api-dto/generated/RoadRunner/Centrifugal/Proxy/DTO/V1/Disconnect.php:37",
      "stacktrace": [
        {
          "function": "Google\\Protobuf\\Internal\\Message->__construct()"
        },
        {
          "function": "RoadRunner\\Centrifugal\\Proxy\\DTO\\V1\\Disconnect->__construct()"
        },
        {
          "function": "RoadRunner\\Centrifugo\\Request\\AbstractRequest->disconnect()"
        },
        ]
   }
}

How To Reproduce

Call disconnect on a request coming from Centrifugo - RequestInterface. The code fails here: https://github.com/roadrunner-php/centrifugo/blob/2.x/src/Request/AbstractRequest.php#L67 because the Disconnect DTO is missing the reconnect field.

Additional Info

Q A
Package Version latest
PHP version 8.3.2
Operating system Linux
FZambia commented 5 months ago

Reconnect flag was removed in Centrifugo v5

Also, from Centrifugo docs:

Application must use numbers in the range 4000-4999 for custom disconnect codes: codes in range [4000, 4499] give client an advice to reconnect codes in range [4500, 4999] are terminal codes – client won't reconnect upon receiving it.

arizanovj commented 5 months ago

It seems the DTOs in the linked repo were generated from newer (Centrifugo v5) protobuf files and the disconnect function still has the reconnect flag. Needs to be removed in order to support Centrifugo v5.

arizanovj commented 4 months ago

@butschster any thoughts on this?