spiral / roadrunner-bridge

πŸŒ‰ RoadRunner bridge to Spiral Framework
https://spiral.dev/docs/packages-roadrunner-bridge
MIT License
12 stars 6 forks source link

Remove abandoned package #88

Closed msmakouz closed 10 months ago

msmakouz commented 10 months ago
Q A
Bugfix? βœ”οΈ
Breaks BC? ❌
New feature? ❌
Issues #87

We already use the psr/http-factory package in our code. Here: https://github.com/spiral/roadrunner-bridge/blob/3.x/src/Bootloader/HttpBootloader.php#L7

And here: https://github.com/spiral/roadrunner-bridge/blob/3.x/src/Http/Dispatcher.php#L7

The code from the php-http/message-factory package was not used anywhere.

The psr/http-factory package was not added explicitly and was installed because other packages required it. Added it as a dependency.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (aa1716f) 92.87% compared to head (58918b1) 92.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.x #88 +/- ## ========================================= Coverage 92.87% 92.87% Complexity 316 316 ========================================= Files 62 62 Lines 1010 1010 ========================================= Hits 938 938 Misses 72 72 ``` | [Files](https://app.codecov.io/gh/spiral/roadrunner-bridge/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spiral) | Coverage Ξ” | | |---|---|---| | [src/GRPC/Generator/BootloaderGenerator.php](https://app.codecov.io/gh/spiral/roadrunner-bridge/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spiral#diff-c3JjL0dSUEMvR2VuZXJhdG9yL0Jvb3Rsb2FkZXJHZW5lcmF0b3IucGhw) | `99.02% <ΓΈ> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.