search

spiraldb / vortex

A toolkit for working with compressed Arrow in-memory, on-disk, and over-the-wire
Apache License 2.0
92 stars 5 forks source link

Add `ByteBoolArray` type and fixe a bug in `BoolArray` #383

Closed AdamGS closed 1 week ago

AdamGS commented 2 weeks ago

The main two contributions in this PR are:

  1. A new ByteBoolArray type (closes #335)
  2. An important fix for slicing and initialization of BoolArray
gatesn commented 2 weeks ago

The other high-level comment, we should move this encoding into a crate. The main vortex-array encodings are (mostly) only those that convert 1:1 to Arrow. Anything else is an "extension"

AdamGS commented 1 week ago

Pushed fixes for most comment, I think stats are the last thing I need to fix here

AdamGS commented 1 week ago

Seems like one of my recent changes broke tests, looking into Fixed