search

spiralhalo / DramaticLights

Shader for Canvas
GNU General Public License v3.0
5 stars 0 forks source link

Evening colors start far too early #1

Open LemmaEOF opened 4 years ago

LemmaEOF commented 4 years ago

The evening colors start when the sun is still pretty far from setting, so it ends up looking pretty weird against a fully-blue sky.

spiralhalo commented 4 years ago

I'll try to look into it.

It could also be a problem with altitude though, because in my testing the orange sky can be seen earlier in lower altitude, so I did notice a problem with higher altitude but decided it was low priority.

I could try something fancy with y coordinates but I wouldn't expect anything too accurate. Easiest and most guaranteed "fix" would be just to color the sky itself since I don't find vanilla sky to be "dramatic" enough for the effect that I wanted, but that needs to wait for custom sky to become a feature.

LemmaEOF commented 4 years ago

I'm at about y=80 in this.

spiralhalo commented 4 years ago

I was mistaken about altitude. Seems that high altitude can actually see the orange sky much higher above the horizon, but there is no timing difference, so the syncing with vanilla is just bad. Will fix some time later. Thanks for reporting!

spiralhalo commented 4 years ago

I changed the peak sunset time from 12000 to about 12500 and made it shorter in the latest commit. Feel free to close the issue if that improves it for you.